-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to 1ES servicing pools on release/dev16.7-vs-deps #57504
Switch to 1ES servicing pools on release/dev16.7-vs-deps #57504
Conversation
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
@JoeRobich why do we even still have this branch? Shouldn't the -vs-deps branches all be removed at this point? |
We opted to keep the -vs-deps branches as our servicing branches. Helps keep things consistent when releases all come from -vs-deps branches. |
All that being said. This branch is not buildable because it still references myget feeds that are no longer available. We should add the dotnet-public and myget-legacy feeds to the nuget.config. Even then there may be packages we have to hunt down and get published. |
@JoeRobich would you be okay merging this even though the builds are failing in the meantime so we can migrate this off the BuildPools? |
Let me try updating the nuget.config to see if this is an easy fix. |
@JoeRobich Do you have any update on this PR? This is one of the last issues that's blocking us from completing 1ES migration. |
Well, since the branch isn't buildable, there is no reason not to take the change. We would have to do a fair bit of work either way to service this release. Let us merge it and may April come soon. |
Thanks! |
Per https://github.com/dotnet/core-eng/issues/14276.