Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to 1ES servicing pools on release/dev16.7-vs-deps #57504

Conversation

jonfortescue
Copy link
Member

@jonfortescue
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@333fred
Copy link
Member

333fred commented Nov 9, 2021

@JoeRobich why do we even still have this branch? Shouldn't the -vs-deps branches all be removed at this point?

@JoeRobich
Copy link
Member

@JoeRobich why do we even still have this branch? Shouldn't the -vs-deps branches all be removed at this point?

We opted to keep the -vs-deps branches as our servicing branches. Helps keep things consistent when releases all come from -vs-deps branches.

@JoeRobich
Copy link
Member

All that being said. This branch is not buildable because it still references myget feeds that are no longer available. We should add the dotnet-public and myget-legacy feeds to the nuget.config. Even then there may be packages we have to hunt down and get published.

@jonfortescue
Copy link
Member Author

@JoeRobich would you be okay merging this even though the builds are failing in the meantime so we can migrate this off the BuildPools?

@JoeRobich
Copy link
Member

@JoeRobich would you be okay merging this even though the builds are failing in the meantime so we can migrate this off the BuildPools?

Let me try updating the nuget.config to see if this is an easy fix.

@lpatalas
Copy link

@JoeRobich Do you have any update on this PR? This is one of the last issues that's blocking us from completing 1ES migration.

@JoeRobich
Copy link
Member

Do you have any update on this PR?

Well, since the branch isn't buildable, there is no reason not to take the change. We would have to do a fair bit of work either way to service this release. Let us merge it and may April come soon.

@JoeRobich JoeRobich merged commit f8c8414 into dotnet:release/dev16.7-vs-deps Dec 16, 2021
@lpatalas
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants