Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractFlowPass - VisitArrayCreation should use the regular way for visiting initializer. #57612

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

AlekseyTs
Copy link
Contributor

An array initializer node is a valid region designator for the Region Analysis.
Therefore, the analysis should be able to track when we enter/leave the region.
Fixes #57572.

…visiting `initializer`.

An array initializer node is a valid region designator for the Region Analysis.
Therefore, the analysis should be able to track when we enter/leave the region.
Fixes dotnet#57572.
@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler Please review, need a second sign-off.

@AlekseyTs AlekseyTs merged commit cf14a20 into dotnet:main Nov 8, 2021
@ghost ghost added this to the Next milestone Nov 8, 2021
@allisonchou allisonchou modified the milestones: Next, 17.1.P2 Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnalyzeDataFlow fails for InitializerExpressionSyntax if it is a child of an ArrayCreationExpressionSyntax
4 participants