Tiny simplification to the compilation tracker. #57628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Nov 8, 2021
| // If same language then we can wrap the other project's compilation into a compilation reference | ||
| if (this.ProjectState.LanguageServices == fromProject.LanguageServices) | ||
| { | ||
| // otherwise, base it off the compilation by building it first. | ||
| compilation = await this.GetCompilationAsync(solution, cancellationToken).ConfigureAwait(false); | ||
| var compilation = await this.GetCompilationAsync(solution, cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
GetCompilationAsync already fastpaths if TryGetCompilation returns a value. So no need for the above fast path
JoeRobich
approved these changes
Nov 8, 2021
genlu
approved these changes
Nov 8, 2021
jasonmalinowski
approved these changes
Nov 9, 2021
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.