Remove weakref that telemetry indicates has no impact at all. #57803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Nov 16, 2021
| : new WeakValueSource<AssemblyMetadata>(newMetadata); | ||
|
|
||
| if (!_metadataCache.GetOrAddMetadata(key, metadataValueSource, out metadata)) | ||
| if (!_metadataCache.GetOrAddMetadata(key, new ConstantValueSource<Optional<AssemblyMetadata>>(newMetadata), out metadata)) |
There was a problem hiding this comment.
metadata cache still uses RecoverableMetadataValueSource below. so we need to keep this as a ValueSource.
This was referenced Nov 16, 2021
jasonmalinowski
approved these changes
Nov 16, 2021
ghost
added
the
|
@CyrusNajmabadi Were you expecting this PR to include code changes? |
No. I believe all the changes went in with #58212. Not sure why this didn't close out entirely. |
ryzngard
added
UX Review Not Required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB experiment shows no significant impact of this code decision on any metrics:
We had 450 people reporting around 150k telemetry points. No regressions found.