Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache the delegate for static method group conversions. #58288

Merged
merged 73 commits into from
Jan 13, 2022
Merged

Cache the delegate for static method group conversions. #58288

merged 73 commits into from
Jan 13, 2022

Commits on Dec 12, 2021

  1. Cache the delegate for static method group conversions.

    @pawchen
    pawchen committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    9978f93 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2021

  1. Use static local functions for the delegate caching tests.

    @pawchen
    pawchen committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    0130613 View commit details
    Browse the repository at this point in the history

  2. Fix a flaw in choosing the container type that targets a local function.

    @pawchen
    pawchen committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    1daafd8 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2021

  1. Add some tests for tuples and local functions.

    @pawchen
    pawchen committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    08d1544 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary stuffs.

    @pawchen
    pawchen committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    3afc667 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2021

  1. Feedback: Avoid targeted new for places where types are not immediate… 

    …ly clear.
    @pawchen
    pawchen committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    e03960f View commit details
    Browse the repository at this point in the history

  2. Feedback: Add doc comments.

    @pawchen
    pawchen committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    846f163 View commit details
    Browse the repository at this point in the history

  3. Feedback: Use shared instances.

    @pawchen
    pawchen committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    6f9c4ab View commit details
    Browse the repository at this point in the history

  4. Feedback: Rename and optimize.

    @pawchen
    pawchen committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    dc5c5bd View commit details
    Browse the repository at this point in the history

  5. Rename.

    @pawchen
    pawchen committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    346f1c0 View commit details
    Browse the repository at this point in the history

  6. Feedback: Share containers for functions with zero arity within the s… 

    …ame generic ancestor function.
    @pawchen
    pawchen committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    9ec9776 View commit details
    Browse the repository at this point in the history

  7. Use MessageID for feature enabling.

    @pawchen
    pawchen committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    af2f823 View commit details
    Browse the repository at this point in the history

  8. Merge with main.

    @pawchen
    pawchen committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    0ba2f89 View commit details
    Browse the repository at this point in the history

  9. Fix test options.

    @pawchen
    pawchen committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    f0b45f9 View commit details
    Browse the repository at this point in the history

  10. Revert file rename.

    @pawchen
    pawchen committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    bb135c1 View commit details
    Browse the repository at this point in the history

  11. Keep existing tests that explicitly target older language versions.

    @pawchen
    pawchen committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    357883b View commit details
    Browse the repository at this point in the history

  12. Feedback: Improve readability.

    @pawchen
    pawchen committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    fef8b7a View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2021

  1. Feedback: Pin affected pre-existing tests to C# 10.

    @pawchen
    pawchen committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    797e281 View commit details
    Browse the repository at this point in the history

  2. Restore original comments and whitespaces.

    @pawchen
    pawchen committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    17e0056 View commit details
    Browse the repository at this point in the history

  3. Move 10 vs preview to the new test file.

    @pawchen
    pawchen committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    97acc82 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2021

  1. Feedback: Remove duplicate information.

    @pawchen
    pawchen committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    87c448b View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2021

  1. Feedback: Adjust TypeSymbol.VisitType and remove the visitor.

    @pawchen
    pawchen committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    55b0171 View commit details
    Browse the repository at this point in the history

  2. Fix IndexOutOfRangeException.

    @pawchen
    pawchen committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    1a75a7f View commit details
    Browse the repository at this point in the history

  3. Remove tuple branch.

    @pawchen
    pawchen committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    656466a View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2021

  1. Feedback: Add asserts.

    @pawchen
    pawchen committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    f5bdc79 View commit details
    Browse the repository at this point in the history

  2. Feedback: Adjust VisitType.

    @pawchen
    pawchen committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    c244c51 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2021

  1. Feedback: Use ancestor cache containers (less arity) when possible.

    @pawchen
    pawchen committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    8c197fe View commit details
    Browse the repository at this point in the history

  2. Add tests for annoymous delegate in anonymous class.

    @pawchen
    pawchen committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    8f85ed6 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2021

  1. Feedback: Remove confusing comments. Add an assert.

    @pawchen
    pawchen committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    0758ddc View commit details
    Browse the repository at this point in the history

  2. Feedback: Update assert. Use static field.

    @pawchen
    pawchen committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    49c7420 View commit details
    Browse the repository at this point in the history

  3. Feedback: Use CSharpCustomModifier.ModifierSymbol.

    @pawchen
    pawchen committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    67429d3 View commit details
    Browse the repository at this point in the history

  4. Feedback: Avoid ImmutableArray allocation.

    @pawchen
    pawchen committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    d0912a9 View commit details
    Browse the repository at this point in the history

  5. Fix var scope.

    @pawchen
    pawchen committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    48c5cd7 View commit details
    Browse the repository at this point in the history

  6. Feedback: Add direct tests for VisitType.

    @pawchen
    pawchen committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    3784e4a View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2021

  1. Merge branch 'main' of https://github.com/dotnet/roslyn into mgcClean

    @pawchen
    pawchen committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    9ecd5bd View commit details
    Browse the repository at this point in the history

  2. Feedback: Remove commented code.

    @pawchen
    pawchen committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    5113cdc View commit details
    Browse the repository at this point in the history

  3. Add test with custom modifiers with type parameter.

    @pawchen
    pawchen committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    1d98b32 View commit details
    Browse the repository at this point in the history

  4. Simplify container validations when possible. Add type parameter veri… 

    …fication for custom modifiers.
    @pawchen
    pawchen committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    fcb0159 View commit details
    Browse the repository at this point in the history

  5. Feedback: Remove unused method.

    @pawchen
    pawchen committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    60b72d6 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2021

  1. Use AssertEx.NotNull.

    @pawchen
    pawchen committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    ee75f3c View commit details
    Browse the repository at this point in the history

  2. Add IL verification for cases we shouldn't cache.

    @pawchen
    pawchen committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    764c863 View commit details
    Browse the repository at this point in the history

  3. Test the actual interested method.

    @pawchen
    pawchen committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    cb66daf View commit details
    Browse the repository at this point in the history

  4. Add an overload of VerifySynthesizedFields that also perform validati… 

    …ons against the emitted assembly.
    @pawchen
    pawchen committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    194e320 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2022

  1. Add IL verifications show that the container and fields are used.

    @pawchen
    pawchen committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    7c75892 View commit details
    Browse the repository at this point in the history

  2. Prepare for EnC tests.

    @pawchen
    pawchen committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    fd2d727 View commit details
    Browse the repository at this point in the history

  3. Pass the previous ParseOptions to the next compilation.

    @pawchen
    pawchen committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    b6c09d6 View commit details
    Browse the repository at this point in the history

  4. Add EnC tests.

    @pawchen
    pawchen committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    b26d098 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2022

  1. Merge branch 'main' of https://github.com/dotnet/roslyn into mgcClean

    @pawchen
    pawchen committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    e26476c View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. Add VerifyNoCacheContainers that also verifies the produced assembly.… 

    … Add tests for target typed new.
    @pawchen
    pawchen committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    ef66214 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into mgcClean

    @pawchen
    pawchen authored Jan 5, 2022
    Configuration menu
    Copy the full SHA
    0f25a6e View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2022

  1. Merge branch 'main' of https://github.com/dotnet/roslyn into mgcClean

    @pawchen
    pawchen committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    9ca84f4 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2022

  1. Feedback: Use regular type cast and move to a shared library.

    @pawchen
    pawchen committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    1eed89b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'mgcClean' of https://github.com/diryboy/roslyn into mgc… 

    …Clean
    @pawchen
    pawchen committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    9f4a296 View commit details
    Browse the repository at this point in the history

  3. Feedback: Use regular type cast. Revert "Move to a shared library." 

    This reverts commit 1eed89b.
    @pawchen
    pawchen committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    c985538 View commit details
    Browse the repository at this point in the history

  4. Feedback: Use the symbolValidator parameter.

    @pawchen
    pawchen committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    eecb17b View commit details
    Browse the repository at this point in the history

  5. Add tests for conversions from instances.

    @pawchen
    pawchen committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    67dfa96 View commit details
    Browse the repository at this point in the history

  6. Feedback: Remove a duplicated C# 10 test case.

    @pawchen
    pawchen committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    35de0aa View commit details
    Browse the repository at this point in the history

  7. Feedback: Print the expression tree.

    @pawchen
    pawchen committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    75a11cc View commit details
    Browse the repository at this point in the history

  8. Feedback: Add name ambiguity tests.

    @pawchen
    pawchen committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    35a9f64 View commit details
    Browse the repository at this point in the history

  9. Fix expectedOutput for expression lamba.

    @pawchen
    pawchen committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    0ed19da View commit details
    Browse the repository at this point in the history

  10. Add an assert.

    @pawchen
    pawchen committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    e9cb8a9 View commit details
    Browse the repository at this point in the history

  11. Rename helper methods.

    @pawchen
    pawchen committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    e659853 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Merge branch 'main' of https://github.com/dotnet/roslyn into mgcClean

    @pawchen
    pawchen committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    7b2bbea View commit details
    Browse the repository at this point in the history

  2. Feedback: Move EnC tests from Emit2 to Emit.

    @pawchen
    pawchen committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    ffe1c99 View commit details
    Browse the repository at this point in the history

  3. Feedback: Only compare CLR signature for the cache fields.

    @pawchen
    pawchen committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    c0f729c View commit details
    Browse the repository at this point in the history

  4. Address some feedback.

    @pawchen
    pawchen committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    336c95b View commit details
    Browse the repository at this point in the history

  5. Feedback: Explicitly target some tests to C# Next.

    @pawchen
    pawchen committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    e673d05 View commit details
    Browse the repository at this point in the history

  6. Add a test where the target is a local function outside of the curren… 

    …t function.
    @pawchen
    pawchen committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    3679330 View commit details
    Browse the repository at this point in the history

  7. Feedback: Add an assert.

    @pawchen
    pawchen committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    af2d179 View commit details
    Browse the repository at this point in the history

  8. Feedback: Rename the custom comparer.

    @pawchen
    pawchen committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    ebb945e View commit details
    Browse the repository at this point in the history

  9. Feedback: Use ReferenceEqualityComparer.

    @pawchen
    pawchen committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    aaa2621 View commit details
    Browse the repository at this point in the history

  10. Feedback: Add a test for C# 10. Add tests for cache field sharing the… 

    … same anonymous delegate.
    @pawchen
    pawchen committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    28ffe27 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2022

  1. Address feedback.

    @pawchen
    pawchen committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    84551f1 View commit details
    Browse the repository at this point in the history