-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move component model code to common location for all AbstractPackages #58397
Move component model code to common location for all AbstractPackages #58397
Conversation
src/VisualStudio/Core/Def/Implementation/LanguageService/AbstractPackage.cs
Show resolved
Hide resolved
using Microsoft.VisualStudio.Shell; | ||
using Task = System.Threading.Tasks.Task; | ||
|
||
namespace Microsoft.VisualStudio.LanguageServices.Implementation.LanguageService | ||
{ | ||
internal abstract class AbstractPackage : AsyncPackage | ||
{ | ||
private IComponentModel _componentModel_doNotAccessDirectly; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 Not a huge fan of _doNotAccessDirectly
here... but hopefully this can be removed once we can have partial-auto-properties.
…actPackage.cs Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
|
||
protected override async Task InitializeAsync(CancellationToken cancellationToken, IProgress<ServiceProgressData> progress) | ||
{ | ||
await JoinableTaskFactory.SwitchToMainThreadAsync(cancellationToken); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this still need to call the base.InitiaizeAsync too?
using Microsoft.VisualStudio.Shell; | ||
using Task = System.Threading.Tasks.Task; | ||
|
||
namespace Microsoft.VisualStudio.LanguageServices.Implementation.LanguageService | ||
{ | ||
internal abstract class AbstractPackage : AsyncPackage | ||
{ | ||
private IComponentModel _componentModel_doNotAccessDirectly; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to at least #nullable enable this bit and make the field nullable?
…di/roslyn into shareComponentModel
No description provided.