Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused message argument #58432

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Conversation

333fred
Copy link
Member

@333fred 333fred commented Dec 20, 2021

While adjusting this code in the required-members branch I noticed the parameter is unused by the error message, so I did a small refactoring in main to clean that up.

While adjusting this code in the required-members branch I noticed the parameter is unused by the error message, so I did a small refactoring in main to clean that up.
Copy link
Contributor

@chsienki chsienki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@333fred
Copy link
Member Author

333fred commented Dec 20, 2021

@AlekseyTs could you take a look as well?

Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@333fred 333fred enabled auto-merge (squash) December 20, 2021 23:14
@333fred 333fred merged commit e01c235 into dotnet:main Dec 21, 2021
@ghost ghost added this to the Next milestone Dec 21, 2021
@333fred 333fred deleted the remove-unused-arg branch December 21, 2021 01:16
@Cosifne Cosifne modified the milestones: Next, 17.1.P3 Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants