Improve support for TestWorkspace with source generated files #58455
Conversation
| [Fact] | ||
| public async Task DoIncludeSymbolsFromMultipleSourceGeneratedFiles() | ||
| { | ||
| using var workspace = TestWorkspace.CreateCSharp( |
There was a problem hiding this comment.
can the xml syntax cannot support this scenario?
There was a problem hiding this comment.
all the other tests in this file use the xml syntax so I would prefer if we kept things consistent
There was a problem hiding this comment.
➡️ I needed one test to use the new code so we can see it's working. Both work; but the XML form is clumsier. Eventually it would be nice to provide an object model similar to Microsoft.CodeAnalysis.Testing.
There was a problem hiding this comment.
but the XML form is clumsier
Is this a style question or are there bugs that we don't find by testing with one or the other?
I can agree that testing via XML is much nicer in VB and would be fine if we used a different teat api surface area in C# vs VB. However, without some additional benefit beyond ergonomics I can't say I think it would be worth the exercise.
There was a problem hiding this comment.
It doesn't have a schema, so there's no real completion support. I'm not a fan of the reliance on copy/pasting from some other existing test which occurs even when writing VB code.
I'm not sure whether we validate the complete contents of the XML markup (e.g. if an attribute is misspelled but still valid XML, do we fail?).
ghost
added this to the 
Extracted from #58363 to simplify the review.
The full review is relatively simple, but each commit is constructed as a distinct change that can be reviewed separately.