Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enqueue additional and analyzer config documents in WorkCoordinator #58479

Merged
merged 2 commits into from
Dec 24, 2021

Conversation

mavasani
Copy link
Contributor

Fixes #53192
Currently, work coordinator only enqueues source document IDs for project analysis work items. This means we don't analyze the additional documents, which can now report standalone diagnostics through RegisterAdditionalFileAction. This PR fixes this by enqueuing project's additional document IDs and analyzer config document IDs.

Fixes dotnet#53192
Currently, work coordinator only enqueues source document IDs for project analysis work items. This means we don't analyze the additional documents, which can now report standalone diagnostics through RegisterAdditionalFileAction. This PR fixes this by enqueuing project's additional document IDs and analyzer config document IDs.
@mavasani mavasani added this to the 17.1 milestone Dec 24, 2021
@mavasani mavasani requested review from sharwell and a team December 24, 2021 05:37
@mavasani mavasani merged commit 957f8b3 into dotnet:main Dec 24, 2021
@mavasani mavasani deleted the WorkcoordinatorFix branch December 24, 2021 16:20
@ghost ghost modified the milestones: 17.1, Next Dec 24, 2021
@Cosifne Cosifne modified the milestones: Next, 17.1.P3 Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roslyn Analyzer not clearing last diagnostic
3 participants