Add UnitTestingGlobalOptions to External Access to make global options accessible to Unit Testing #59070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/roslyn-ide PTAL |
tmat
commented
Jan 26, 2022
| @@ -33,6 +33,7 @@ internal UnitTestingRemoteHostClient(ServiceHubRemoteHostClient client, UnitTest | |||
| return new UnitTestingRemoteHostClient((ServiceHubRemoteHostClient)client, serviceDescriptors, callbackDispatchers); | |||
| } | |||
|
|
|||
| [Obsolete("Use UnitTestingGlobalOptions.IsServiceHubProcessCoreClr instead")] | |||
| public static bool IsServiceHubProcessCoreClr(HostWorkspaceServices services) | |||
| { | |||
| var optionServices = services.GetRequiredService<IOptionService>(); | |||
There was a problem hiding this comment.
This is problematic since we do not want global options to be accessed from remote workspace layer and potentially oop where they are not available.
2 tasks
JoeRobich
approved these changes
Jan 26, 2022
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up Unit Testing PR:
https://devdiv.visualstudio.com/DevDiv/_git/VSUnitTesting/pullrequest/375882