-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement handling of rename intent #59410
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
16c64bf
Implement handling of rename intent
dibarbet 16dfe1d
Merge remote-tracking branch 'upstream/main' into rename_intent
dibarbet c3f004f
Merge remote-tracking branch 'upstream/main' into rename_intent
dibarbet 6fdefcd
Use documentId instead of URI
dibarbet afbdc58
Move record definition up top
dibarbet 1dd735d
feedback
dibarbet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
160 changes: 160 additions & 0 deletions
160
src/EditorFeatures/CSharpTest/Intents/RenameIntentTests.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,160 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
|
||
using System.Linq; | ||
using System.Threading.Tasks; | ||
using Microsoft.CodeAnalysis.Features.Intents; | ||
using Microsoft.CodeAnalysis.Test.Utilities; | ||
using Microsoft.CodeAnalysis.Text; | ||
using Xunit; | ||
|
||
namespace Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.Intents; | ||
|
||
[UseExportProvider] | ||
public class RenameIntentTests : IntentTestsBase | ||
{ | ||
[Fact] | ||
public async Task TestRenameIntentAsync() | ||
{ | ||
var initialText = | ||
@"class C | ||
{ | ||
void M() | ||
{ | ||
var thing = 1; | ||
{|typed:something|}.ToString(); | ||
} | ||
}"; | ||
var expectedText = | ||
@"class C | ||
{ | ||
void M() | ||
{ | ||
var something = 1; | ||
something.ToString(); | ||
} | ||
}"; | ||
|
||
await VerifyExpectedRenameAsync(initialText, expectedText, "thing", "something").ConfigureAwait(false); | ||
} | ||
|
||
[Fact] | ||
public async Task TestRenameIntentAsync_Insert() | ||
{ | ||
var initialText = | ||
@"class C | ||
{ | ||
void M() | ||
{ | ||
var thing = 1; | ||
{|typed:some|}thing.ToString(); | ||
} | ||
}"; | ||
var expectedText = | ||
@"class C | ||
{ | ||
void M() | ||
{ | ||
var something = 1; | ||
something.ToString(); | ||
} | ||
}"; | ||
|
||
await VerifyExpectedRenameAsync(initialText, expectedText, string.Empty, "something").ConfigureAwait(false); | ||
} | ||
|
||
[Fact] | ||
public async Task TestRenameIntentAsync_Delete() | ||
{ | ||
var initialText = | ||
@"class C | ||
{ | ||
void M() | ||
{ | ||
var something = 1; | ||
{|typed:|}thing.ToString(); | ||
} | ||
}"; | ||
var expectedText = | ||
@"class C | ||
{ | ||
void M() | ||
{ | ||
var thing = 1; | ||
thing.ToString(); | ||
} | ||
}"; | ||
|
||
await VerifyExpectedRenameAsync(initialText, expectedText, "some", "thing").ConfigureAwait(false); | ||
} | ||
|
||
[Fact] | ||
public async Task TestRenameIntentAsync_MultipleFiles() | ||
{ | ||
var initialText = | ||
@"namespace M | ||
{ | ||
public class C | ||
{ | ||
public static string {|typed:BetterString|} = string.Empty; | ||
|
||
void M() | ||
{ | ||
var m = SomeString; | ||
} | ||
} | ||
}"; | ||
var additionalDocuments = new string[] | ||
{ | ||
@"namespace M | ||
{ | ||
public class D | ||
{ | ||
void M() | ||
{ | ||
var m = C.SomeString; | ||
} | ||
} | ||
}" | ||
}; | ||
|
||
var expectedTexts = new string[] | ||
{ | ||
@"namespace M | ||
{ | ||
public class C | ||
{ | ||
public static string BetterString = string.Empty; | ||
|
||
void M() | ||
{ | ||
var m = BetterString; | ||
} | ||
} | ||
}", | ||
@"namespace M | ||
{ | ||
public class D | ||
{ | ||
void M() | ||
{ | ||
var m = C.BetterString; | ||
} | ||
} | ||
}" | ||
}; | ||
|
||
await VerifyExpectedRenameAsync(initialText, additionalDocuments, expectedTexts, "SomeString", "BetterString").ConfigureAwait(false); | ||
} | ||
|
||
private static Task VerifyExpectedRenameAsync(string initialText, string expectedText, string priorText, string newName) | ||
{ | ||
return VerifyExpectedTextAsync(WellKnownIntents.Rename, initialText, expectedText, intentData: $"{{ \"newName\": \"{newName}\" }}", priorText: priorText); | ||
} | ||
|
||
private static Task VerifyExpectedRenameAsync(string initialText, string[] additionalText, string[] expectedTexts, string priorText, string newName) | ||
{ | ||
return VerifyExpectedTextAsync(WellKnownIntents.Rename, initialText, additionalText, expectedTexts, intentData: $"{{ \"newName\": \"{newName}\" }}", priorText: priorText); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename requires us to support multiple document changes. instead of outright removing this, obsoleting until intellicode can react to avoid dual insertion