-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LSP breakpoint placement #59428
LSP breakpoint placement #59428
Conversation
src/Features/LanguageServer/Protocol/Handler/Breakpoints/ValidateBreakableRangeHandler.cs
Outdated
Show resolved
Hide resolved
src/Features/LanguageServer/Protocol/Handler/Breakpoints/ValidateBreakableRangeHandler.cs
Outdated
Show resolved
Hide resolved
src/Features/LanguageServer/Protocol/Handler/Breakpoints/ValidateBreakableRangeHandler.cs
Outdated
Show resolved
Hide resolved
src/Features/LanguageServer/Protocol/Handler/Breakpoints/ValidateBreakableRangeHandler.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can tell who designed the LSP spec when the handler implementation is this simple 😛
|
||
var text = await document.GetTextAsync(cancellationToken).ConfigureAwait(false); | ||
var span = ProtocolConversions.RangeToTextSpan(request.Range, text); | ||
var breakpointService = document.Project.LanguageServices.GetRequiredService<IBreakpointResolutionService>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this break for non-c#/vb @dibarbet shoudl we make this GetService and then return null if it's not available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think its necessary - we should just not advertise the capability for other scenarios
This change has broken ngen in our isnertion FYI @RikkiGibson
Looks like Microsoft.VisualStudio.LanguageServer.Protocol 17.2.3 isn't inserted in VS or there's issue with ngen time binding redirect. |
Looks like 17.2.3 insertion is not merged yet - https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/382251 |
Implements #59455
LSP: microsoft/language-server-protocol#1401