Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP breakpoint placement #59428

Merged
merged 5 commits into from
Feb 25, 2022
Merged

LSP breakpoint placement #59428

merged 5 commits into from
Feb 25, 2022

Conversation

tmat
Copy link
Member

@tmat tmat commented Feb 9, 2022

@tmat tmat enabled auto-merge (squash) February 24, 2022 21:11
Copy link
Contributor

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can tell who designed the LSP spec when the handler implementation is this simple 😛

@tmat tmat merged commit cd9b31f into dotnet:main Feb 25, 2022
@ghost ghost modified the milestones: 17.2, Next Feb 25, 2022

var text = await document.GetTextAsync(cancellationToken).ConfigureAwait(false);
var span = ProtocolConversions.RangeToTextSpan(request.Range, text);
var breakpointService = document.Project.LanguageServices.GetRequiredService<IBreakpointResolutionService>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this break for non-c#/vb @dibarbet shoudl we make this GetService and then return null if it's not available?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think its necessary - we should just not advertise the capability for other scenarios

@tmat tmat deleted the LSPBreakpoints branch February 25, 2022 17:07
@genlu
Copy link
Member

genlu commented Feb 25, 2022

This change has broken ngen in our isnertion FYI @RikkiGibson

02/25/2022 10:03:22.907 [4344]: Failed to load dependency Microsoft.VisualStudio.LanguageServer.Protocol.Internal of assembly Microsoft.CodeAnalysis.EditorFeatures, Version=4.2.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35 because of the following error : The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
02/25/2022 10:03:22.907 [4344]: Failed to load dependency Microsoft.VisualStudio.LanguageServer.Protocol of assembly Microsoft.CodeAnalysis.EditorFeatures, Version=4.2.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35 because of the following error : The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
02/25/2022 10:03:22.923 [4344]: Failed to load dependency Microsoft.VisualStudio.LanguageServer.Protocol.Extensions of assembly Microsoft.CodeAnalysis.EditorFeatures, Version=4.2.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35 because of the following error : The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)

Looks like Microsoft.VisualStudio.LanguageServer.Protocol 17.2.3 isn't inserted in VS or there's issue with ngen time binding redirect.

@dibarbet
Copy link
Member

Looks like 17.2.3 insertion is not merged yet - https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/382251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants