Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add external access APIs for O# #59469

Merged
merged 11 commits into from
Feb 23, 2022
Merged

Add external access APIs for O# #59469

merged 11 commits into from
Feb 23, 2022

Conversation

tmat
Copy link
Member

@tmat tmat commented Feb 10, 2022 •
edited
Loading

Corresponding O# PR: OmniSharp/omnisharp-roslyn#2343

Depends on dotnet/roslyn-sdk#967

TODO:

  • OmniSharpDocumentationCommentsSnippetService

@tmat tmat requested review from a team as code owners February 10, 2022 23:50
@tmat
Copy link
Member Author

tmat commented Feb 10, 2022

@JoeRobich

@tmat tmat mentioned this pull request Feb 11, 2022
Merged
@tmat
Copy link
Member Author

tmat commented Feb 11, 2022 •
edited
Loading

@JoeRobich @ryzngard One more commit to pass IDE analyzer options through (rebased on #58765).

@tmat
Copy link
Member Author

tmat commented Feb 11, 2022 •
edited
Loading

Turns out changes to Roslyn SDK are needed. dotnet/roslyn-sdk#967, dotnet/roslyn-sdk#969

@tmat tmat enabled auto-merge (squash) February 14, 2022 23:42
@tmat
Copy link
Member Author

tmat commented Feb 16, 2022

#59575 needed to fix failing tests.

@tmat tmat disabled auto-merge February 22, 2022 23:45
@tmat tmat merged commit 03016af into dotnet:main Feb 23, 2022
@tmat tmat deleted the OmniSharpEA branch February 23, 2022 06:26
@ghost ghost added this to the Next milestone Feb 23, 2022
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P2 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

@ryzngard ryzngard ryzngard approved these changes

@mgoertz-msft mgoertz-msft mgoertz-msft approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.2.P2
Development

Successfully merging this pull request may close these issues.
5 participants
@tmat @ryzngard @JoeRobich @mgoertz-msft @RikkiGibson