Value Tracking: Remove inproc symbol usage #59473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nding in the command handler
davidwengier
approved these changes
Feb 11, 2022
tmat
reviewed
Feb 11, 2022
src/VisualStudio/Core/Def/ValueTracking/ValueTrackedTreeItemViewModel.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Feb 11, 2022
src/VisualStudio/Core/Def/ValueTracking/ValueTrackingCommandHandler.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Feb 11, 2022
src/VisualStudio/Core/Def/ValueTracking/ValueTrackingCommandHandler.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Feb 11, 2022
src/VisualStudio/Core/Def/ValueTracking/ValueTrackingCommandHandler.cs
Outdated
Show resolved
Hide resolved
| return null; | ||
| } | ||
|
|
||
| var semanticModel = await document.GetRequiredSemanticModelAsync(cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
oh thank goodness. so now nothign symbolic happens on the client side right? it's all on the server?
genlu
approved these changes
Feb 17, 2022
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove symbol usage in the Value Tracking command handler, and use the
IValueTrackingServiceinstead to find the right symbol at the root.Fixes #59378