Use segmented arrays for VirtualChar storage #59503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
approved these changes
Feb 11, 2022
| @@ -862,5 +863,33 @@ internal static bool IsSorted<T>(this ImmutableArray<T> array, IComparer<T> comp | |||
|
|
|||
| return ~low; | |||
| } | |||
|
|
|||
| internal static int BinarySearch<TElement, TValue>(this ImmutableSegmentedList<TElement> array, TValue value, Func<TElement, TValue, int> comparer) | |||
There was a problem hiding this comment.
public? up to you but that's my pref.
There was a problem hiding this comment.
➡️ Will keep like this only because it matches the one above
sharwell
force-pushed
the
loh-virtualchar
branch
from
cb22c04
to
e6d73d1
Compare
chsienki
approved these changes
Feb 23, 2022
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AB#1460018