Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing project references to Core deployment #59566

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Add missing project references to Core deployment #59566

merged 1 commit into from
Feb 15, 2022

Conversation

tmat
Copy link
Member

@tmat tmat commented Feb 15, 2022 •
edited
Loading

@tmat tmat requested a review from a team as a code owner February 15, 2022 20:50
@genlu
Copy link
Member

genlu commented Feb 15, 2022

We'd need both this and #59554, right?

genlu
genlu approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@genlu genlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should just add those dependencies to MS.CA.Remote.ServiceHub.csproj directly

@tmat
Copy link
Member Author

tmat commented Feb 15, 2022

I wonder if we should just add those dependencies to MS.CA.Remote.ServiceHub.csproj directly

I don't think we should. The code in Remote.ServiceHub should not have direct dependencies on language specific features. It should imo be up to the "setup" projects to compose these together.

@tmat
Copy link
Member Author

tmat commented Feb 15, 2022

We'd need both this and #59554, right?

Not sure. I don't think we actually need #59554, but we will see...

@genlu
Copy link
Member

genlu commented Feb 15, 2022 •
edited
Loading

It appears the corehost leg is now passing. But based on what you said yesterday, I'd expect it to fail w/o #59554 though. 🤔

@tmat tmat merged commit bbf4733 into dotnet:main Feb 15, 2022
@ghost ghost added this to the Next milestone Feb 15, 2022
@tmat tmat deleted the FixCoreLayout branch February 15, 2022 23:05
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P2 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genlu genlu genlu approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.2.P2
Development

Successfully merging this pull request may close these issues.
3 participants
@tmat @genlu @RikkiGibson