Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print method name and hexadecimal offsets in ILVerify output #59583

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Print method name and hexadecimal offsets in ILVerify output #59583

merged 2 commits into from
Feb 18, 2022

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Feb 16, 2022 •
edited
Loading

Example of output (when a test fails):

[Equals]: Unexpected type on the stack. { Offset = 0x14, Found = readonly address of '[2a6d4de6-6689-4dbf-adb0-6547f1df848a]System.Index', Expected = address of '[2a6d4de6-6689-4dbf-adb0-6547f1df848a]System.Index' }

@jcouv jcouv self-assigned this Feb 16, 2022
@jcouv jcouv marked this pull request as ready for review February 17, 2022 04:07
@jcouv jcouv requested a review from a team as a code owner February 17, 2022 04:07
@jcouv jcouv changed the title Print method name in ILVerify output Print method name and hexadecimal offsets in ILVerify output Feb 17, 2022
AlekseyTs
AlekseyTs approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 2)

@jcouv jcouv merged commit 36dc033 into dotnet:main Feb 18, 2022
@jcouv jcouv deleted the ilverify-method branch February 18, 2022 01:00
@ghost ghost added this to the Next milestone Feb 18, 2022
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P2 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers
Projects
None yet
Milestone
17.2.P2
Development

Successfully merging this pull request may close these issues.
4 participants
@jcouv @333fred @AlekseyTs @RikkiGibson