Port more tests #59587
Merged
Port more tests #59587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
commented
Feb 16, 2022
src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/ShellInProcess.cs
Outdated
Show resolved
Hide resolved
dibarbet
approved these changes
Feb 16, 2022
| VisualStudio.Editor.Verify.CodeAction($"Upgrade this project to C# language version '{version}'", applyFix: true); | ||
| // Suspend file change notification during code action application, since spurious file change notifications | ||
| // can cause silent failure to apply the code action if they occur within this block. | ||
| await using (var fileChangeRestorer = await TestServices.Shell.PauseFileChangesAsync(HangMitigatingCancellationToken)) |
There was a problem hiding this comment.
It might be useful to extract this helper to a core helper method on the EditorVerifiter perhaps? e.g. InvokeFixAsync(string name, applyFix:..., cancellationToken) and re-use that here + CSharpUpdateProjectToAllowUnsafe.cs
There was a problem hiding this comment.
I'll keep it like this for now. The short term goal is eliminate this requirement (all cases where this appear are bugs that users will hit because they don't have the workaround).
sharwell
force-pushed
the
port-more-tests
branch
from
337d8f4
to
6f94f3d
Compare
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.