Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move VisualStudioProject.BatchingDocumentCollection to it's own file #59589

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

jasonmalinowski
Copy link
Member

This is just a direct invocation of the refactoring; no other work was done.

This is just a direct invocation of the refactoring; no other work
was done.
@jasonmalinowski jasonmalinowski merged commit d90251c into dotnet:main Feb 17, 2022
@jasonmalinowski jasonmalinowski deleted the split-up-file branch February 17, 2022 01:41
@ghost ghost added this to the Next milestone Feb 17, 2022
@sharwell
Copy link
Member

💡 The name of the type contained in this file is VisualStudioProject+BatchingDocumentCollection, so the preferred file name here would be VisualStudioProject+BatchingDocumentCollection.cs.

@jasonmalinowski
Copy link
Member Author

@sharwell Roslyn team convention historically was to use a period -- if we want to switch to a new standard we should do so as a separate decision. We should also update the code to fix to actually follow that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants