Additional tests for lambda attributes, explicit return type, and inferred delegate type #59634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
reviewed
Feb 18, 2022
| @@ -399,6 +399,33 @@ public void TestNormalizeStatement1() | |||
| TestNormalizeStatement("Func<string, int> f = blah;", "Func<string, int> f = blah;"); | |||
| } | |||
|
|
|||
| [Theory] | |||
| [InlineData("[return:A]void Local([B]object o){}", "[return: A]\r\nvoid Local([B] object o)\r\n{\r\n}")] | |||
There was a problem hiding this comment.
nit: Consider making the input worse (literally the opposite for every position where possible on the attributes):
Suggested change
| [InlineData("[return:A]void Local([B]object o){}", "[return: A]\r\nvoid Local([B] object o)\r\n{\r\n}")] | |
| [InlineData("[ return:A ]void Local( [ B ]object o){}", "[return: A]\r\nvoid Local([B] object o)\r\n{\r\n}")] | |
| ``` #Closed |
jcouv
reviewed
Feb 18, 2022
| UsingTree(source, TestOptions.Regular9); | ||
| verify(); | ||
|
|
||
| UsingTree(source, TestOptions.RegularNext); |
There was a problem hiding this comment.
Seems like this should be Regular10 (we only need to use RegularNext when we mean Regular11 which doesn't exist yet) #Resolved
jcouv
reviewed
Feb 18, 2022
| UsingExpression(source, TestOptions.Regular9); | ||
| verify(); | ||
|
|
||
| UsingExpression(source, TestOptions.RegularNext); |
jcouv
reviewed
Feb 18, 2022
|
|
||
| var symbolInfo = model.GetSymbolInfo(returnTypeSyntax); | ||
| Assert.Equal(expectedType, symbolInfo.Symbol); | ||
| } |
There was a problem hiding this comment.
Did you find the stress test that has deeply nested lambdas? We could add a variant where the return type removes the "stress". #Resolved
There was a problem hiding this comment.
Added OverloadResolutionPerfTests.NestedLambdas_WithParameterAndReturnTypes().
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add various tests identified in test plan #52192 ...
Attributes
Parsing
Semantics
LambdaTests.LambdaAttributes_AttributeSemanticModel())Explicit return type
Syntax
async MyMethod() => null;on the top level parses as a local function statement with a return type ofasyncSemantics
returnstatement types and declared return typeOverloadResolutionPerfTests.NestedLambdas_WithParameterAndReturnTypes())LambdaTests.LambdaReturnType_SemanticModel())LambdaTests.LambdaReturnType_SemanticModel())Inferred (natural) delegate type
Semantics
var_ = () => {};(not really useful, but is this allowed?)System.DelegatetypeGetTypeInfo()should return the inferred delegate type for method groups #52874)GetSymbolInfo()should return the resolved method from a method group with inferred delegate type #52870)