Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed odd naming suggestions #59674

Merged
merged 9 commits into from
Feb 27, 2022
Merged

Fixed odd naming suggestions #59674

merged 9 commits into from
Feb 27, 2022

Conversation

DoctorKrolic
Copy link
Contributor

@DoctorKrolic DoctorKrolic commented Feb 20, 2022 •
edited
Loading

Fixes: #36364

  1. Fixes wrong naming suggestion for collections of basic types, like IEnumerable<string>
  2. Improves naming suggestion for generics, e.g. IEnumerable<T> -> values, IEnumerable<TResult> -> results, IEnumerable<TParam> -> @params

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner February 20, 2022 18:36
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Feb 20, 2022
@CyrusNajmabadi
Copy link
Member

Looks awesome. Thanks!

@DoctorKrolic
Copy link
Contributor Author

I suppose, auto-merge is blocked here, because 1 of required CI checks failed. However, I think that I am not responsible for it, or am I?

@CyrusNajmabadi
Copy link
Member

You are not. We'll shepherd this in.

@CyrusNajmabadi CyrusNajmabadi merged commit f494b56 into dotnet:main Feb 27, 2022
@ghost ghost added this to the Next milestone Feb 27, 2022
@DoctorKrolic DoctorKrolic deleted the fix-naming-suggestions branch February 27, 2022 09:58
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P2 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier left review comments

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees

@CyrusNajmabadi CyrusNajmabadi

Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
17.2.P2
Development

Successfully merging this pull request may close these issues.

Odd suggested parameter names in some cases
4 participants
@DoctorKrolic @CyrusNajmabadi @davidwengier @RikkiGibson