Simplify goto def command handler #59769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Feb 25, 2022
| @@ -98,8 +99,6 @@ internal static bool TryExecuteCommand(Document document, int caretPosition, IGo | |||
| var notificationService = workspace.Services.GetService<INotificationService>(); | |||
| notificationService.SendNotification(errorMessage, title: EditorFeaturesResources.Go_to_Definition, severity: NotificationSeverity.Information); | |||
| } | |||
|
|
|||
| return true; | |||
| } | |||
There was a problem hiding this comment.
this method always returned 'true', so could just simplify the stack all the way up.
Cosifne
approved these changes
Feb 25, 2022
sharwell
reviewed
Feb 25, 2022
| @@ -66,13 +65,14 @@ class C | |||
| Dim mockDocumentNavigationService = | |||
| DirectCast(workspace.Services.GetService(Of IDocumentNavigationService)(), MockDocumentNavigationService) | |||
|
|
|||
| GoToDefinitionCommandHandler.TryExecuteCommand(view.TextSnapshot, baseDocument.CursorPosition.Value, TestCommandExecutionContext.Create()) | |||
| Dim handler = New GoToDefinitionCommandHandler() | |||
There was a problem hiding this comment.
📝 This should be obtained through the MEF catalog instead of directly constructed. Looks like it's not the only case where this is happening though, so not a blocker at this point. Just makes it more work when we do eventually clean it up.
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.