Address layering of navigation action in code actions #59856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmalinowski
approved these changes
Mar 2, 2022
|
|
||
| public DocumentNavigationOperation(DocumentId documentId, int position = 0) | ||
| public DocumentNavigationOperation(DocumentId documentId!!, int position = 0) |
There was a problem hiding this comment.
had to remove as well, was getting formatting warnings :'(
| { | ||
| var navigationOperation = operations.OfType<DocumentNavigationOperation>().FirstOrDefault(); |
There was a problem hiding this comment.
Consider SingleOrDefault, since if we have more than one I'm suspicious about what happened there.
There was a problem hiding this comment.
well SingleOrDefault throws... and that worries me about somethign potentially throwing now taht just had wonky behavior before.
| if (workspace.CanOpenDocuments) | ||
| { | ||
| var navigationService = workspace.Services.GetService<IDocumentNavigationService>(); | ||
| var threadingService = workspace.Services.GetService<IWorkspaceThreadingServiceProvider>(); |
There was a problem hiding this comment.
Can you delete IWorkspaceThreadingServiceProvider or did something else still use it too?
There was a problem hiding this comment.
unfortunately, unit testing and TS are still using it in exactly 2 locations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.