Revert "Push the two-step navigation system further through roslyn." #59949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this; at this point the Roslyn PR appears to be a red herring -- either another component broke their ngen, or ngen randomly failed, and that's causing the increase in JIT and change in assembly load. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#59802 is suspected of introducing RPS regressions.
Last known good: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/383846
First known bad: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/383867
Revert validation: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=5837378&view=results
Regressed counters:
Please advise whether the failures are plausibly connected with this PR, and if so, whether we should revert, or take a follow-up PR to fix, or seek an exception. @genlu @CyrusNajmabadi @jasonmalinowski.