Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BoundArrayInitialization.IsInferred #60391

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Add BoundArrayInitialization.IsInferred #60391

merged 2 commits into from
Mar 31, 2022

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Mar 25, 2022

Fixes #60376

@jcouv jcouv self-assigned this Mar 25, 2022
@jcouv jcouv marked this pull request as ready for review March 26, 2022 03:22
@jcouv jcouv requested a review from a team as a code owner March 26, 2022 03:22
AlekseyTs
AlekseyTs reviewed Mar 28, 2022
View reviewed changes
src/Compilers/CSharp/Portable/BoundTree/BoundNodes.xml Outdated
@@ -1984,6 +1984,7 @@
</Node>

<Node Name="BoundArrayInitialization" Base="BoundExpression">
<Field Name="IsInferred" Type="bool"/>
Copy link
Contributor

@AlekseyTs AlekseyTs Mar 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IsInferred

Consider adding a comment. Also, I think we generally following an unspoken convention that "Type" is the first property in the node description. #Closed

AlekseyTs
AlekseyTs approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@jcouv
Copy link
Member Author

jcouv commented Mar 30, 2022

@dotnet/roslyn-compiler for second review. Thanks

@jcouv
Copy link
Member Author

jcouv commented Mar 31, 2022 •
edited
Loading

@roslyn-compiler for second review. Thanks

@jcouv jcouv merged commit 764dcd0 into dotnet:main Mar 31, 2022
@jcouv jcouv deleted the array-init branch March 31, 2022 23:33
@ghost ghost added this to the Next milestone Mar 31, 2022
@AlekseyTs AlekseyTs mentioned this pull request Apr 1, 2022
Merged
333fred added a commit that referenced this pull request Apr 4, 2022
@333fred
Merge remote-tracking branch 'upstream/main' into merges/main-to-feat…
975137e 
…ures/semi-auto-props

* upstream/main: (110 commits)
  Add Rebuild badge to README (#60298)
  Update PublishData.json for 17.3 P1 (#60559)
  Note auto-default merged in feature status doc (#60564)
  Update Roslyn.Diagnostics.Analyzers and remove RS0005 suppressions
  Cleanup unused resources in Features layer
  Remove unnecessary `<Compile Remove`
  Remove overrides in Features
  Remove overrides in Analyzers
  Remove the single unused read of CodeFixCategory
  Remove unused abstract property
  Update Language Feature Status.md (#60482)
  Document ROSLYN_TEST_USEDASSEMBLIES (#60478)
  Add BoundArrayInitialization.IsInferred (#60391)
  Add an aggregate logger for inheritance margin (#60493)
  Move StackTraceAnalyzer over to VirtualCharSequence (#60404)
  PR feedback
  Fix test and review feedback
  Update Spanish queue to Windows.10.Amd64.Server2022.ES.Open
  Enable NRT in AbstractSyncNamespaceCodeRefactoringProvider
  test
  ...
@dibarbet dibarbet modified the milestones: Next, 17.3.P1 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@cston cston cston approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers
Projects
None yet
Milestone
17.3.P1
Development

Successfully merging this pull request may close these issues.

Avoid checking array/stackalloc creation syntax in NullableWalker
4 participants
@jcouv @AlekseyTs @cston @dibarbet