Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SetsRequiredMembersAttribute #60392

Merged
merged 14 commits into from
Apr 15, 2022

Commits on Mar 25, 2022

  1. Support SetsRequiredMembersAttribute

    The SetsRequiredMembersAttribute prevents the compiler from checking the required member list of a type when calling that constructor, and suppresses any errors from a base type's list being invalid.
    
    Specification: https://github.com/dotnet/csharplang/blob/main/proposals/required-members.md
    Test plan: dotnet#57046
    333fred committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    7761d6b View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2022

  1. Correct test issues.

    333fred committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    a4dd570 View commit details
    Browse the repository at this point in the history
  2. Fix EE compile.

    333fred committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    a9aef94 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2022

  1. Configuration menu
    Copy the full SHA
    95d08c1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d9da29b View commit details
    Browse the repository at this point in the history
  3. PR feedback.

    333fred committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    72c3927 View commit details
    Browse the repository at this point in the history
  4. Readd condition.

    333fred committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    49a53a5 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2022

  1. Use SuppressRequiredMembers to inform nullable analysis of whether pr…

    …operties should be considered initialized.
    333fred committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    3984820 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e69ef15 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2022

  1. Merge remote-tracking branch 'upstream/features/required-members' int…

    …o setsrequiredmembers
    
    * upstream/features/required-members: (808 commits)
      Update for definite assignment changes
      Remove duplicate package references (dotnet#60658)
      Formatting and code generation options (dotnet#60127)
      Trim unnessasary leading lines when removing usings (dotnet#60672)
      Pass options to FixAllAsync, simplify CodeAction registration (dotnet#60665)
      Fallout
      Lint
      Restore CodeStyle test projects
      Update struct field definite assignment tests
      Global indentation options - take 2 (dotnet#60565)
      Run continuation to dispose of cancellation token source (dotnet#60653)
      Fixup
      Update tests
      Cleanup
      Cleanup
      move properties
      Delay starting the work to scan for todo-items
      Simplify
      Clean up syntax context
      Clean up syntax context
      ...
    333fred committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    06acf5f View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2022

  1. Add restriction that SetsRequiredMembersAttribute must be applied whe…

    …n chaining to a constructor with the attribute. Add more tests.
    333fred committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    4cfdf57 View commit details
    Browse the repository at this point in the history
  2. Remove erroneous assert.

    333fred committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    e7e4947 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2022

  1. Merge remote-tracking branch 'upstream/features/required-members' int…

    …o setsrequiredmembers
    
    * upstream/features/required-members: (66 commits)
      Fix dotnet#55183: Add SymbolVisitor<TArgument, TResult> (dotnet#56530)
      Simplifier options (dotnet#60174)
      Remove duplicated asset
      Do not try to refcount solution syncing when communicating with OOP
      Delay symbol-search index updating until solution is fully loaded.
      add more miscellaneous tests for checked operators (dotnet#60727)
      Support checked operators in explicit interface implementation (dotnet#60715)
      Avoid formatting diagnostics with raw strings (dotnet#60655)
      Make heading levels for warning waves documentation consistent (dotnet#60721)
      Clean up IDiagnosticService extension methods
      Remove #nullable enable
      Add integration test to flag MEF composition breaks
      Generate static abstract interface members correctly (dotnet#60618)
      Merge release/dev17.2 to main (dotnet#60682)
      Fix FAR on checked operators (dotnet#60698)
      Add implement interface support for checked operators and cast operators (dotnet#60719)
      Update csc.dll path in launch.json (dotnet#60663)
      Grab bag of UTF8 string support in IDE features (dotnet#60599)
      Allow code actions to retrieve options for any language (dotnet#60697)
      Fix flaky VSTypeScriptHandlerTests  (dotnet#60706)
      ...
    333fred committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    728b6da View commit details
    Browse the repository at this point in the history
  2. PR Feedback.

    333fred committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    106378e View commit details
    Browse the repository at this point in the history