Move StackTraceAnalyzer over to VirtualCharSequence

src/Features/Core/Portable/Microsoft.CodeAnalysis.Features.csproj

@@ -57,6 +57,7 @@
     <InternalsVisibleTo Include="AnalyzerRunner" />
     <InternalsVisibleTo Include="Microsoft.CodeAnalysis.EditorFeatures2.UnitTests" />
     <InternalsVisibleTo Include="Microsoft.CodeAnalysis.Workspaces.Test.Utilities" />
+    <InternalsVisibleTo Include="IdeBenchmarks" />
     <!-- BEGIN MONODEVELOP
     These MonoDevelop dependencies don't ship with Visual Studio, so can't break our
     binary insertions and are exempted from the ExternalAccess adapter assembly policies.

src/Features/Core/Portable/StackTraceExplorer/DefaultStackParser.cs

@@ -2,13 +2,15 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+using System;
 using System.Diagnostics.CodeAnalysis;
+using Microsoft.CodeAnalysis.EmbeddedLanguages.VirtualChars;
 
 namespace Microsoft.CodeAnalysis.StackTraceExplorer
 {
     internal sealed class DefaultStackParser : IStackFrameParser
     {
-        public bool TryParseLine(string line, [NotNullWhen(true)] out ParsedFrame? parsedFrame)
+        public bool TryParseLine(VirtualCharSequence line, [NotNullWhen(true)] out ParsedFrame? parsedFrame)
         {
             // For now we just keep all text so the user can still see lines they pasted and they
             // don't disappear. In the future we might want to restrict what we show.

src/Features/Core/Portable/StackTraceExplorer/DotnetStackFrameParser.cs

@@ -2,8 +2,10 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+using System;
 using System.Diagnostics.CodeAnalysis;
 using Microsoft.CodeAnalysis.EmbeddedLanguages.StackFrame;
+using Microsoft.CodeAnalysis.EmbeddedLanguages.VirtualChars;
 
 namespace Microsoft.CodeAnalysis.StackTraceExplorer
 {
@@ -12,7 +14,7 @@ internal sealed class DotnetStackFrameParser : IStackFrameParser
         /// <summary>
         /// Uses <see cref="StackFrameParser"/> to parse a line if possible
         /// </summary>
-        public bool TryParseLine(string line, [NotNullWhen(true)] out ParsedFrame? parsedFrame)
+        public bool TryParseLine(VirtualCharSequence line, [NotNullWhen(true)] out ParsedFrame? parsedFrame)
         {
             parsedFrame = null;
             var tree = StackFrameParser.TryParse(line);

src/Features/Core/Portable/StackTraceExplorer/IStackFrameParser.cs

@@ -2,12 +2,14 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+using System;
 using System.Diagnostics.CodeAnalysis;
+using Microsoft.CodeAnalysis.EmbeddedLanguages.VirtualChars;
 
 namespace Microsoft.CodeAnalysis.StackTraceExplorer
 {
     internal interface IStackFrameParser
     {
-        bool TryParseLine(string line, [NotNullWhen(returnValue: true)] out ParsedFrame? parsedFrame);
+        bool TryParseLine(VirtualCharSequence line, [NotNullWhen(returnValue: true)] out ParsedFrame? parsedFrame);
     }
 }

src/Features/Core/Portable/StackTraceExplorer/IgnoredFrame.cs

@@ -2,20 +2,23 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+using System;
+using Microsoft.CodeAnalysis.EmbeddedLanguages.VirtualChars;
+
 namespace Microsoft.CodeAnalysis.StackTraceExplorer
 {
     internal sealed class IgnoredFrame : ParsedFrame
     {
-        private readonly string _originalText;
+        private readonly VirtualCharSequence _originalText;
 
-        public IgnoredFrame(string originalText)
+        public IgnoredFrame(VirtualCharSequence originalText)
         {
             _originalText = originalText;
         }
 
         public override string ToString()
         {
-            return _originalText;
+            return _originalText.CreateString();
         }
     }
 }

src/Features/Core/Portable/StackTraceExplorer/StackTraceAnalysisResult.cs

@@ -11,11 +11,14 @@ namespace Microsoft.CodeAnalysis.StackTraceExplorer
     internal readonly struct StackTraceAnalysisResult
     {
         public StackTraceAnalysisResult(
+            string originalString,
             ImmutableArray<ParsedFrame> parsedLines)
         {
+            OriginalString = originalString;
             ParsedFrames = parsedLines;
         }
 
+        public string OriginalString { get; }
         public ImmutableArray<ParsedFrame> ParsedFrames { get; }
     }
 }

src/Features/Core/Portable/StackTraceExplorer/StackTraceAnalyzer.cs

@@ -9,6 +9,8 @@
 using System.Threading;
 using System.Threading.Tasks;
 using Microsoft.CodeAnalysis.EmbeddedLanguages.StackFrame;
+using Microsoft.CodeAnalysis.EmbeddedLanguages.VirtualChars;
+using Microsoft.CodeAnalysis.Text;
 
 namespace Microsoft.CodeAnalysis.StackTraceExplorer
 {
@@ -29,16 +31,32 @@ internal static class StackTraceAnalyzer
         public static Task<StackTraceAnalysisResult> AnalyzeAsync(string callstack, CancellationToken cancellationToken)
         {
             var parsedFrames = Parse(callstack, cancellationToken);
-            return Task.FromResult(new StackTraceAnalysisResult(parsedFrames.ToImmutableArray()));
+            return Task.FromResult(new StackTraceAnalysisResult(callstack, parsedFrames.ToImmutableArray()));
         }
 
         private static IEnumerable<ParsedFrame> Parse(string callstack, CancellationToken cancellationToken)
         {
-            foreach (var line in SplitLines(callstack))
+            // if the callstack comes from ActivityLog.xml it has been
+            // encoding to be passed over HTTP. This should only decode 
+            // specific characters like "&gt;" and "&lt;" to their "normal"
+            // equivalents ">" and "<" so we can parse correctly
+            callstack = WebUtility.HtmlDecode(callstack);
+
+            var sequence = VirtualCharSequence.Create(0, callstack);
+
+            foreach (var line in SplitLines(sequence))
             {
                 cancellationToken.ThrowIfCancellationRequested();
 
-                var trimmedLine = line.Trim();
+                // For now do the work to removing leading and trailing whitespace. 
+                // This keeps behavior we've had, but may not actually be the desired behavior in the long run.
+                // Specifically if we ever want to add a copy feature to copy back contents from a frame
+                var trimmedLine = Trim(line);
+
+                if (trimmedLine.IsEmpty)
+                {
+                    continue;
+                }
 
                 foreach (var parser in s_parsers)
                 {
@@ -51,17 +69,48 @@ private static IEnumerable<ParsedFrame> Parse(string callstack, CancellationToke
             }
         }
 
-        private static readonly char[] s_lineSplit = new[] { '\n' };
+        private static IEnumerable<VirtualCharSequence> SplitLines(VirtualCharSequence callstack)
+        {
+            var position = 0;
+
+            for (var i = 0; i < callstack.Length; i++)
+            {
+                if (callstack[i].Value == '\n')
+                {
+                    yield return callstack.GetSubSequence(TextSpan.FromBounds(position, i));
 
-        private static IEnumerable<string> SplitLines(string callstack)
+                    // +1 to skip over the \n character
+                    position = i + 1;
+                }
+            }
+
+            if (position < callstack.Length)
+            {
+                yield return callstack.GetSubSequence(TextSpan.FromBounds(position, callstack.Length));
+            }
+        }
+
+        private static VirtualCharSequence Trim(VirtualCharSequence virtualChars)
         {
-            // if the callstack comes from ActivityLog.xml it has been
-            // encoding to be passed over HTTP. This should only decode 
-            // specific characters like "&gt;" and "&lt;" to their "normal"
-            // equivalents ">" and "<" so we can parse correctly
-            callstack = WebUtility.HtmlDecode(callstack);
+            if (virtualChars.Length == 0)
+            {
+                return virtualChars;
+            }
+
+            var start = 0;
+            var end = virtualChars.Length - 1;
+
+            while (virtualChars[start].IsWhiteSpace && start < end)
+            {
+                start++;
+            }
+
+            while (virtualChars[end].IsWhiteSpace && end > start)
+            {
+                end--;
+            }
 
-            return callstack.Split(s_lineSplit, StringSplitOptions.RemoveEmptyEntries);
+            return virtualChars.GetSubSequence(TextSpan.FromBounds(start, end + 1));
         }
     }
 }

src/Features/Core/Portable/StackTraceExplorer/VSDebugCallstackParser.cs

@@ -7,12 +7,13 @@
 using System.Diagnostics.CodeAnalysis;
 using Microsoft.CodeAnalysis.Text;
 using Microsoft.CodeAnalysis.EmbeddedLanguages.StackFrame;
+using Microsoft.CodeAnalysis.EmbeddedLanguages.VirtualChars;
 
 namespace Microsoft.CodeAnalysis.StackTraceExplorer
 {
     internal sealed class VSDebugCallstackParser : IStackFrameParser
     {
-        public bool TryParseLine(string line, [NotNullWhen(true)] out ParsedFrame? parsedFrame)
+        public bool TryParseLine(VirtualCharSequence line, [NotNullWhen(true)] out ParsedFrame? parsedFrame)
         {
             // Example line:
             // ConsoleApp4.dll!ConsoleApp4.MyClass.ThrowAtOne() Line 19	C#
@@ -21,14 +22,22 @@ public bool TryParseLine(string line, [NotNullWhen(true)] out ParsedFrame? parse
             parsedFrame = null;
 
             // +1 here because we always want to skip the '!' character
-            var startPoint = line.IndexOf('!') + 1;
+            var startPoint = -1;
+            for (var i = 0; i < line.Length; i++)
+            {
+                if (line[i].Value == '!')
+                {
+                    startPoint = 0;
+                    break;
+                }
+            }
 
-            if (startPoint == 0 || startPoint == line.Length)
+            if (startPoint <= 0 || startPoint == line.Length)
             {
                 return false;
             }
 
-            var textToParse = line[startPoint..];
+            var textToParse = line.GetSubSequence(TextSpan.FromBounds(startPoint, line.Length));
             var tree = StackFrameParser.TryParse(textToParse);
 
             if (tree is null)