Inline Diagnostics: Fix conflicting diagnostics and general code cleanup #60468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
reviewed
Mar 29, 2022
| @@ -284,7 +284,7 @@ protected bool ShouldDrawTag(SnapshotSpan snapshotSpan, IMappingTagSpan<T> mappi | |||
| } | |||
|
|
|||
| var mappedPoint = TextView.BufferGraph.MapUpToSnapshot( | |||
| point.Value, PointTrackingMode.Negative, PositionAffinity.Predecessor, TextView.VisualSnapshot); | |||
| point.Value, PointTrackingMode.Negative, PositionAffinity.Predecessor, TextView.TextSnapshot); | |||
There was a problem hiding this comment.
Because I am curious, what is the difference between these?
There was a problem hiding this comment.
I am not quite sure what the difference is to be honest, but I did MapUpToSnapshot earlier in the file as well and I used the TextSnapshot. This was just to keep consistency because I don't think I used the VisualSnapshot for a particular reason.
There was a problem hiding this comment.
can you make sure that if you scroll these off screen that they disappear (debugging through to amek sure that happens would be good too).
JoeRobich
reviewed
Mar 29, 2022
JoeRobich
reviewed
Mar 30, 2022
| var graphicsResult = tag.GetGraphics(TextView, geometry, GetFormat(classificationType)); | ||
|
|
||
| // Pass in null! because the geometry is unused for drawing anything for Inline Diagnostics | ||
| var graphicsResult = tag.GetGraphics(TextView, null!, GetFormat(classificationType)); |
There was a problem hiding this comment.
Suggested change
| var graphicsResult = tag.GetGraphics(TextView, null!, GetFormat(classificationType)); | |
| var graphicsResult = tag.GetGraphics(TextView, unused: null!, GetFormat(classificationType)); |
JoeRobich
approved these changes
Mar 30, 2022
CyrusNajmabadi
approved these changes
Mar 30, 2022
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.