Fix the KeybindingResetDetector

[jasonmalinowski]

We switched VisualStudioInfoBar to no longer be a MEF service in 347cd02, but this was still importing it. It's now a helper type, so create it instead.

[CyrusNajmabadi]

We switched VisualStudioInfoBar to no longer be a MEF service in 347cd02, but this was still importing it.

How did that not break everything? e.g. i would have expected some sort of exceptions happening that should have caused problems. Do we have an exception hole somewhere?

[CyrusNajmabadi]

i don't get it. shouldn't this have broken mef? how was this type getting instantiated? and how did this not break anything else importing KeybindingResetDetector?

[jasonmalinowski]

This type is only instantiated here:

roslyn/src/VisualStudio/Core/Def/RoslynPackage.cs

Lines 260 to 261 in 91bd6e5

	// Initialize keybinding reset detector
	await ComponentModel.DefaultExportProvider.GetExportedValue<KeybindingReset.KeybindingResetDetector>().InitializeAsync().ConfigureAwait(true);

which is just a general "let's initialize it". Nothing else MEF imports this.

[davkean]

This line is hiding it:

roslyn/src/VisualStudio/Core/Def/RoslynPackage.cs

Line 227 in 91bd6e5

LoadComponentsBackgroundAsync(cancellationToken).Forget();

. It's just a Forget - no fault or anything.

[CyrusNajmabadi]

Something doesn't make sense to me here.

[jasonmalinowski]

@CyrusNajmabadi: It throws exceptions here:

roslyn/src/VisualStudio/Core/Def/RoslynPackage.cs

Lines 260 to 261 in 91bd6e5

	// Initialize keybinding reset detector
	await ComponentModel.DefaultExportProvider.GetExportedValue<KeybindingReset.KeybindingResetDetector>().InitializeAsync().ConfigureAwait(true);

Which is a fire-and-forget path.

[CyrusNajmabadi]

bleaghhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh.

[jasonmalinowski]

@CyrusNajmabadi Updated to report non-fatal telemetry if that throws.

[jasonmalinowski]

Some testing makes us think this feature is more generally broken; until we understand why we'll merge this for 17.3 to avoid the MEF composition issue, and we'll need to investigate further.