Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using --blame-crash with CollectDumps #60561

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Avoid using --blame-crash with CollectDumps #60561

merged 1 commit into from
Apr 4, 2022

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Apr 4, 2022

This flag causes the test harness to attach ProcDump, which removes our ability to collect heap dumps on crash using Windows' built-in functionality.

@sharwell sharwell requested a review from a team as a code owner April 4, 2022 19:00
jasonmalinowski
jasonmalinowski requested changes Apr 4, 2022
View reviewed changes
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs be conditioned more carefully, because we still would want this running on Linux or other Helix scenarios where we aren't running the Windows support.

@sharwell sharwell changed the title Avoid using --blame-crash Avoid using --blame-crash on Windows Apr 4, 2022
@sharwell
Avoid using --blame-crash with CollectDumps
b7b37c3 
This flag causes the test harness to attach ProcDump, which removes our
ability to collect heap dumps on crash using Windows' built-in
functionality.
@sharwell sharwell changed the title Avoid using --blame-crash on Windows Avoid using --blame-crash with CollectDumps Apr 4, 2022
@sharwell sharwell enabled auto-merge April 4, 2022 22:39
@sharwell sharwell merged commit 318d44c into dotnet:main Apr 4, 2022
@ghost ghost added this to the Next milestone Apr 4, 2022
@sharwell sharwell deleted the no-blame-crash branch April 5, 2022 14:21
@dibarbet dibarbet modified the milestones: Next, 17.3.P1 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure
Projects
None yet
Milestone
17.3.P1
Development

Successfully merging this pull request may close these issues.
3 participants
@sharwell @jasonmalinowski @dibarbet