Delay starting the work to scan for todo-items #60654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
approved these changes
Apr 8, 2022
| { | ||
| // Have to catch all exceptions coming through here as this is called from a | ||
| // fire-and-forget method and we want to make sure nothing leaks out. | ||
| try | ||
| { | ||
| // Don't bother doing anything until the workspae has actually loaded. We don't want to add to any | ||
| // startup costs by doing work too early. |
There was a problem hiding this comment.
should we consider not doing anything at all until someone opens the todo comment window? I don't think I've ever opened it, so for people like me it seems like there is no point in this even running.
There was a problem hiding this comment.
Yes. taht woudl make a ton of sense. let me see what we can do about that.
CyrusNajmabadi
commented
Apr 8, 2022
| ProcessTodoCommentInfosAsync, | ||
| _asyncListener, | ||
| cancellationToken)); | ||
| var cancellationToken = _disposalToken; |
There was a problem hiding this comment.
not sure why this was lazily created.
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/1466973.