Do not try to refcount solution syncing when communicating with OOP #60753
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This logic is correct on the OOP side. However, on the client side it is broken. Specifically, consider this set of interleaved concurrent operations on the client side and OOP:
Client Side:
OOP side:
The real fix here will need to be that on the client side we keep these checksum->scope-id mappings around with a refcount as well, so that we only remove from teh client mapping once all concurrent calls actually finish.
In the meantime though, stop trying to share the syncing computation and instead have all calls create their own concurrent sync that is safe from other operations being canceled.