Filter out RequiredMemberAttribute from metadata symbols
#63497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/roslyn-compiler for review. |
|
Although I'm not conceptually against this, does the compiler do this in other cases too? I wasn't sure if we ever came to a decision on this. |
Yes, in a number of places. The filtering code is the code I touched here, so you can see existing attributes that are removed by examining the diff. |
|
Do we need to do anything for VB? |
We will likely need to do something as part of #61435, but for now no. |
|
@dotnet/roslyn-compiler for reviews. |
AlekseyTs
reviewed
Aug 22, 2022
src/Compilers/CSharp/Portable/Symbols/Metadata/PE/PEFieldSymbol.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Aug 22, 2022
src/Compilers/CSharp/Portable/Symbols/Metadata/PE/PENamedTypeSymbol.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Aug 22, 2022
src/Compilers/CSharp/Portable/Symbols/Metadata/PE/PEPropertySymbol.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Aug 22, 2022
|
@dotnet/roslyn-compiler for a second review. |
AlekseyTs
reviewed
Aug 23, 2022
AlekseyTs
reviewed
Aug 23, 2022
AlekseyTs
reviewed
Aug 23, 2022
|
@AlekseyTs added a test to verify order of access doesn't affect observable results. |
|
@dotnet/roslyn-compiler for a second review please. |
AlekseyTs
reviewed
Aug 24, 2022
RikkiGibson
approved these changes
Aug 25, 2022
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61511.