Upgrade System.Memory to fully fix another MSBuild loading issue

[jasonmalinowski]

This works around dotnet/msbuild#7873

Fixes #63409 (along with #63527)

[jaredpar]

Has mantis signed off on this since it can impact VS load?

@chsienki

[chsienki]

Presumably it's already being loaded, so shouldn't make a difference, but might want to do a val build just to be sure.

[jasonmalinowski]

I see System.Memory being referenced by Roslyn.VisualStudio.Setup.Dependencies.csproj which implies we just pick up whatever VS has inserted. I also see it being added to the ExpressionEvaluatior ResultProvider, but I don't know what that means.

I suspect that means this can't break much, which is a great reason to run a validation build. 😄

[jasonmalinowski]

@chsienki So looking at the VS build I triggered for this, it appears VS is already using the newer version. Naturally, this means this upgrade still breaks the VS build itself for reasons I need to investigate further.

[JoeRobich]

Stinks that projects which reference both M.CA and NuGet libs would now end up with a version mismatch. A lot of System.Memory 4.5.4 deps out there. =(

[jasonmalinowski]

The internal build is now passing, so @dotnet/roslyn-infrastructure or @dotnet/roslyn-ide could I get a signoff on this?