Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution services cleanup #64160

Merged
merged 4 commits into from
Jan 23, 2023
Merged

Solution services cleanup #64160

merged 4 commits into from
Jan 23, 2023

Conversation

tmat
Copy link
Member

@tmat tmat commented Sep 20, 2022 •
edited
Loading

Removes some references to Workspace and HostWorkspaceServices.

@tmat tmat force-pushed the SolutionServicesCleanup branch from 4fbc0b1 to 7d5cd01 Compare October 18, 2022 15:36
@tmat tmat marked this pull request as ready for review October 18, 2022 15:43
@tmat tmat requested a review from a team as a code owner October 18, 2022 15:43
@tmat
Copy link
Member Author

tmat commented Oct 18, 2022

@CyrusNajmabadi @jasonmalinowski

@tmat tmat force-pushed the SolutionServicesCleanup branch 2 times, most recently from fcdd864 to 2fe67fb Compare October 20, 2022 20:17
@tmat tmat force-pushed the SolutionServicesCleanup branch from 2fe67fb to 21db9d3 Compare November 10, 2022 22:51
@build-analysis build-analysis bot mentioned this pull request Nov 11, 2022
Closed
5 tasks
@tmat tmat force-pushed the SolutionServicesCleanup branch from c802014 to 8a685cf Compare November 21, 2022 20:40
This was referenced Nov 21, 2022
Closed
Closed
@tmat tmat force-pushed the SolutionServicesCleanup branch from 8a685cf to 01c5ad2 Compare December 4, 2022 02:47
@tmat tmat force-pushed the SolutionServicesCleanup branch 2 times, most recently from c1d93e8 to 896ac9c Compare January 8, 2023 19:27
jasonmalinowski
jasonmalinowski reviewed Jan 10, 2023
View reviewed changes
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much of this PR is all goodness, but I think I have a few requests for comments and one or two places to validate things just to make sure this isn't going to break some subtle stuff.

src/VisualStudio/Core/Def/Watson/FaultReporter.cs Outdated Show resolved Hide resolved
src/Workspaces/Core/Portable/Workspace/Host/LanguageServices.cs Outdated Show resolved Hide resolved
src/Workspaces/Core/Portable/Workspace/Host/SolutionServices.cs Outdated Show resolved Hide resolved
src/Workspaces/Core/Portable/Workspace/Solution/Project.cs Outdated Show resolved Hide resolved
src/Workspaces/Core/Portable/Workspace/Solution/Project.cs Outdated Show resolved Hide resolved
src/Workspaces/Core/Portable/Workspace/Solution/ProjectState.cs Show resolved Hide resolved
src/Workspaces/Core/Portable/Workspace/Solution/Solution.cs Show resolved Hide resolved
src/Workspaces/Core/Portable/Workspace/Solution/Solution.cs Show resolved Hide resolved
src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.cs Outdated Show resolved Hide resolved
src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.cs Show resolved Hide resolved
@tmat tmat force-pushed the SolutionServicesCleanup branch from 896ac9c to 2d61320 Compare January 12, 2023 02:32
@tmat tmat mentioned this pull request Jan 15, 2023
Closed
@tmat
Copy link
Member Author

tmat commented Jan 17, 2023

@jasonmalinowski ping

@tmat tmat enabled auto-merge (squash) January 23, 2023 17:33
@tmat tmat force-pushed the SolutionServicesCleanup branch from 37ca752 to af31cd8 Compare January 23, 2023 22:06
@tmat tmat merged commit 6acaa7b into dotnet:main Jan 23, 2023
@ghost ghost added this to the Next milestone Jan 23, 2023
@tmat tmat deleted the SolutionServicesCleanup branch January 24, 2023 02:23
@Cosifne Cosifne modified the milestones: Next, 17.6 P1 Jan 31, 2023
sharwell added a commit to sharwell/roslyn that referenced this pull request Jun 6, 2023
@sharwell
Update banned APIs to account for dotnet#64160
28cb249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

@CyrusNajmabadi CyrusNajmabadi Awaiting requested review from CyrusNajmabadi

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.6 P1
Development

Successfully merging this pull request may close these issues.
3 participants
@tmat @jasonmalinowski @Cosifne