Add binding redirects for compiler binaries for the LSIF tool #64740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,6 +65,9 @@ | |||
| <PackageReference Include="System.Memory" Version="$(SystemMemoryVersion)" /> | |||
| </ItemGroup> | |||
|
|
|||
| <!-- Since we may be loading analyzers in-process, we need to have the appropriate binding redirects in place --> | |||
There was a problem hiding this comment.
Mind sharing a bit more on what this does?
There was a problem hiding this comment.
So MSBuild has support for generating binding redirects, and generates them based on what reference it sees that needs it: if you are referencing A.dll and B.dll, and B.dll has a different version of A than you're using, it'll add a reference between those. This is an extra set of targets we have in Roslyn which forces binding redirects from 0 up to the deployed version for all compiler binaries, since we need those to be there for back compat. This is also used for csc, vbc, etc.
There was a problem hiding this comment.
ooooo I see I see. Thank you!
NTaylorMullen
approved these changes
Oct 14, 2022
CyrusNajmabadi
approved these changes
Oct 14, 2022
2 tasks
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64491