Out arguments do not contribute val escape #64784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RikkiGibson
force-pushed
the
out-val-escape
branch
from
217d55e to
48c6a89
Compare
RikkiGibson
commented
Nov 22, 2022
| @@ -2427,9 +2432,9 @@ void inferDeclarationExpressionValEscape() | |||
| : GetValEscape(fromArg, scopeOfTheContainingExpression)); | |||
| } | |||
|
|
|||
| foreach (var (_, fromArg, _, _) in escapeValues) | |||
| foreach (var argument in argsOpt) | |||
There was a problem hiding this comment.
Since out arguments are usually not included in escapeValues, we needed to change to check argsOpt instead. Note that escapeValues was probably never the right collection to enumerate, since the same argument can be present multiple times, it just happened to work coincidentally until now.
There was a problem hiding this comment.
Also, although it doesn't look like argsOpt is default-checked on this code path, I actually think that the argument passed for argsOpt is never default. I'll send a separate PR after this one to add an assertion and rename the parameter.
|
@dotnet/roslyn-compiler for review |
jaredpar
approved these changes
Nov 28, 2022
cston
approved these changes
Nov 28, 2022
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #64783
Closes #56587
Although out arguments never contribute their val escape, arguments for
[UnscopedRef] outparameters can contribute their ref escape. See test LocalScope_DeclarationExpression_07.