Fix analyzer consistency checks #64831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue dotnet#64826 outlines the core problem the analyzer consistency check is hitting here and rationale for changing it. In short though this changes our analyzer consistency check in the following ways: 1. It no longer applies on .NET Core. Analyzers get their own `AssemblyLoadContext` hence dependency consistency is not an issue 2. Do not fail consistency check when a dependency is loaded from the GAC 3. Do not fail consistency check when a dependency is loaded from the compiler directory closes dotnet#64826
|
@dotnet/roslyn-compiler PTAL |
cston
approved these changes
Oct 19, 2022
RikkiGibson
approved these changes
Oct 20, 2022
ghost
modified the milestones:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #64826 outlines the core problem the analyzer consistency check is hitting here and rationale for changing it. In short though this changes our analyzer consistency check in the following ways:
AssemblyLoadContexthence dependency consistency is not an issuecloses #64826