Avoid reporting ref safety errors for discard assignments #65693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cston
force-pushed
the
65651
branch
5 times, most recently
from
1bccb86 to
d1f345d
Compare
jcouv
reviewed
Dec 8, 2022
| @@ -182,7 +182,7 @@ internal override BoundStatement BindForEachDeconstruction(BindingDiagnosticBag | |||
| ExpressionSyntax variables = ((ForEachVariableStatementSyntax)_syntax).Variable; | |||
|
|
|||
| // Tracking narrowest safe-to-escape scope by default, the proper val escape will be set when doing full binding of the foreach statement | |||
| var valuePlaceholder = new BoundDeconstructValuePlaceholder(_syntax.Expression, variableSymbol: null, this.LocalScopeDepth, inferredType.Type ?? CreateErrorType("var")); | |||
| var valuePlaceholder = new BoundDeconstructValuePlaceholder(_syntax.Expression, variableSymbol: null, this.LocalScopeDepth, isDiscardExpression: false, inferredType.Type ?? CreateErrorType("var")); | |||
There was a problem hiding this comment.
I believe this placeholder is for the expression rather than iteration variables.
jcouv
reviewed
Dec 8, 2022
| { | ||
| static void F(ref R r) | ||
| { | ||
| foreach ((R r0, _) in new Enumerable1()) break; |
There was a problem hiding this comment.
Consider adding a non-deconstruction variant: foreach (var _ in ...) or foreach (ref var _ in ...) #Closed
There was a problem hiding this comment.
Also, I liked how for deconstruction tests you added the equivalent lowered version (calling Deconstruct). Consider doing the same for foreach-deconstruction scenarios, adding equivalent lowered code.
jcouv
reviewed
Dec 8, 2022
RikkiGibson
approved these changes
Dec 19, 2022
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65522
Fixes #65651
Also fixes an additional issue where the compiler was reporting a ref safety error for deconstruction into an explicitly typed discard - see
RefEscapingTests.Discard_03: