Option key2 #65977
Closed
Option key2 #65977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit simplifies implementation of
GlobalOptionService.SetOptionsandSetGlobalOptionsand clarifies the difference.Next, we replace
OptionKeywithOptionKey2in all Roslyn code that does not deal withOptionSetor other public APIs that expose options. Eventually we'll be able to banOptionKeyinternally. We also push all translations between internal and public code style option values intoSolutionOptionSetand remove them fromGlobalOptionService. The former exposes the values through public API while the latter does not. After this change global options only operate with internal representations. A lot of mechanical changes are needed for this change - the most interesting files to review are:OptionSet.cs,SolutionOptionSet.cs,GlobalOptionService.cs,OptionsHelpers.cs,OptionKeyTest.csandGlobalOptionServiceTests.cs.Adds a new integration test that enumerates all global option definitions in Roslyn assemblies and validates that each of these options can be updated in VS. This addresses test hole where we did not validate reading options from VS settings/registry.
Implements #65394