Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split normalizer tests #66590

Merged
merged 3 commits into from
Feb 2, 2023
Merged

Split normalizer tests #66590

merged 3 commits into from
Feb 2, 2023

Conversation

DoctorKrolic
Copy link
Contributor

As per discussion: #65924 (comment), #65924 (comment).

  • Split TestNormalizeDeclaration1 into smaller logical parts
  • Split TestNormalizeStatement1 into smaller logical parts (this wasn't the part of original discussion, but same rules as for declaration test applies here)
  • Rename TestNormalizeExpression1 -> TestNormalizeDifferentExpressions to better distinguish it form TestNormalizeExpression, which is doing the actual checks

FYI @jcouv

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner January 29, 2023 10:37
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Jan 29, 2023
jcouv
jcouv approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 3)

@jcouv jcouv self-assigned this Feb 2, 2023
@jcouv jcouv added the Test Test failures in roslyn-CI label Feb 2, 2023
@jcouv jcouv enabled auto-merge (squash) February 2, 2023 19:28
@jcouv jcouv merged commit d040ff3 into dotnet:main Feb 2, 2023
@ghost ghost added this to the Next milestone Feb 2, 2023
@DoctorKrolic DoctorKrolic deleted the split-normalizer-tests branch February 2, 2023 22:00
@jcouv
Copy link
Member

jcouv commented Feb 2, 2023

Thanks @DoctorKrolic!

@RikkiGibson RikkiGibson modified the milestones: Next, 17.6 P2 Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. Test Test failures in roslyn-CI
Projects
None yet
Milestone
17.6 P2
Development

Successfully merging this pull request may close these issues.
3 participants
@DoctorKrolic @jcouv @RikkiGibson