Merge release/dev17.6 to main #66674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix inline diagnostics with empty lines * wip - need to get the tests to pass * Revert "wip - need to get the tests to pass" This reverts commit 981abf4. * comment
…_lines Inline Diagnostics - fix multiple empty line bug
…se/dev17.5-vs-deps Merge release/dev17.5 to release/dev17.5-vs-deps
…to-release/dev17.6 Merge release/dev17.5-vs-deps to release/dev17.6
* Reduce copies in shadow load The invariant that our `AnalyzerAssemblyLoader` depends on is the underlying file system is static. Once the contents of an assembly are read off of disk, even if the content is changed and re-registered, the loader will make no attempt to load the new assembly The change in #66492 missed this part of the contract. Upon a new registration via `AddDependencyLocation` it would reset the data for the location and allow new loads to occur. This caused a spike in shadow load copies during VS testing and regressed RPS. This change restores the previous copy behavior and adds test to ensure it's not regressed again. * PR feedback
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from release/dev17.6 into main.
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯
Troubleshooting conflicts
Identify authors of changes which introduced merge conflicts
Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:
Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.
Resolve merge conflicts using your local repo
Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.
git fetch --all git checkout -t upstream/merges/release/dev17.6-to-main git reset --hard upstream/main git merge upstream/release/dev17.6 # Fix merge conflicts git commit git push upstream merges/release/dev17.6-to-main --force