🔨 Enable MSBuild COMM log in bootstrap #66832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a gap where we were calling MSBuild without setting up the COMM log. This uses a bigger hammer approach by setting the ENV variables at the YML level.
jaredpar
commented
Feb 12, 2023
jaredpar
commented
Feb 12, 2023
| } else { | ||
| $args += " /consoleloggerparameters:Verbosity=minimal" | ||
| } | ||
| function Run-MSBuild([string]$projectFilePath, [string]$buildArgs = "", [string]$logFileName = "", [string]$configuration = $script:configuration, [switch]$runAnalyzers = $false) { |
There was a problem hiding this comment.
This is only ever used by the Make-BootstrapBuild function so made it a local function to remove confusion around it. Allowed me to delete several parameter's that weren't being used.
|
Suggest hiding whitespace for this review |
dibarbet
reviewed
Feb 13, 2023
jaredpar
commented
Feb 13, 2023
eng/pipelines/publish-logs.yml
Outdated
| condition: true |
There was a problem hiding this comment.
temp change to validate this is working
dibarbet
approved these changes
Feb 13, 2023
Yes indeed ... should be the default for all YAML changes 😉 |
ghost
added this to the
Cosifne
pushed a commit
to Cosifne/roslyn
that referenced
this pull request
Feb 14, 2023
* 🔨 Enable MSBuild COMM log in bootstrap Fixed a gap where we were calling MSBuild without setting up the COMM log. This uses a bigger hammer approach by setting the ENV variables at the YML level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a gap where we were calling MSBuild without setting up the COMM log. This uses a bigger hammer approach by setting the ENV variables at the YML level.