Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in highlight-refs in multi-language solutions where multiple documents of different languages are open. #67197

Merged
merged 3 commits into from
Mar 6, 2023

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Mar 6, 2023

Fixes AB#1758726

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner March 6, 2023 18:16
Dim symbol = compilation.GetTypeByMetadataName("C")

Dim progress = New StreamingFindReferencesProgressAdapter(NoOpFindReferencesProgress.Instance)
Await SymbolFinder.FindReferencesInDocumentsInCurrentProcessAsync(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this asserting?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that we don't crash :) without the fix this throws.

@CyrusNajmabadi CyrusNajmabadi merged commit aecd498 into dotnet:main Mar 6, 2023
@ghost ghost added this to the Next milestone Mar 6, 2023
@CyrusNajmabadi CyrusNajmabadi deleted the supportsCompilation branch March 6, 2023 20:46
@allisonchou allisonchou modified the milestones: Next, 17.6 P3 Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants