Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interceptors #67432

Merged
merged 50 commits into from
Apr 12, 2023
Merged

Interceptors #67432

merged 50 commits into from
Apr 12, 2023

Conversation

RikkiGibson
Copy link
Contributor

@RikkiGibson RikkiGibson commented Mar 22, 2023 •
edited by jcouv
Loading

Relates to test plan #67421

Feature design is detailed in interceptors.md (included in the PR).

@RikkiGibson RikkiGibson marked this pull request as ready for review March 22, 2023 22:40
@RikkiGibson RikkiGibson requested review from a team as code owners March 22, 2023 22:40
@jcouv jcouv self-assigned this Mar 23, 2023
@AlekseyTs
Copy link
Contributor

It might be hard to review this PR without any clear information what exactly we are trying to achieve and how we are achieving that.

@RikkiGibson @jcouv
Update docs/features/interceptors.md
2ca2c93 
Co-authored-by: Julien Couvreur <jcouv@users.noreply.github.com>
jcouv
jcouv reviewed Apr 11, 2023
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with review pass (iteration 46)

@jcouv jcouv added this to the C# 12.0 milestone Apr 11, 2023
@runfoapp runfoapp bot mentioned this pull request Apr 11, 2023
Open
jcouv
jcouv approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 49) with some minor suggestions from offline discussion

@RikkiGibson RikkiGibson merged commit f77c0b6 into dotnet:features/interceptors Apr 12, 2023
@RikkiGibson RikkiGibson deleted the ic-1 branch April 12, 2023 23:00
@allisonchou allisonchou mentioned this pull request Jun 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi left review comments

@AlekseyTs AlekseyTs AlekseyTs left review comments

@cston cston cston approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers
Projects
None yet
Milestone
C# 12.0
Development

Successfully merging this pull request may close these issues.
6 participants
@RikkiGibson @AlekseyTs @Carsillas @CyrusNajmabadi @cston @jcouv