Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nameof feature status #67794

Merged
merged 5 commits into from
Apr 18, 2023
Merged

Update nameof feature status #67794

merged 5 commits into from
Apr 18, 2023

Conversation

jjonescz
Copy link
Member

Test plan: #67565

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 13, 2023
@@ -10,11 +10,11 @@ efforts behind them.

| Feature | Branch | State | Developer | Reviewer | LDM Champ |
| ------- | ------ | ----- | --------- | -------- | --------- |
| [nameof accessing instance members](https://github.com/dotnet/csharplang/issues/4037) | main | [Merged into 17.7p1](https://github.com/dotnet/roslyn/issues/67565) | [YairHalberstadt](https://github.com/YairHalberstadt), [jjonescz](https://github.com/jjonescz) | [333fred](https://github.com/333fred), [AlekseyTs](https://github.com/AlekseyTs) | [333fred](https://github.com/333fred) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The csharplang proposal has Cyrus as the LDM champion. Which is correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. @333fred @CyrusNajmabadi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked to Cyrus and it sounds like it was Fred.

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the done entry to the top and fixed the links. LGTM Thanks (iteration 3)

@jcouv jcouv self-assigned this Apr 14, 2023
@jcouv jcouv added Documentation and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 14, 2023
@jcouv jcouv enabled auto-merge (squash) April 17, 2023 18:17
@jcouv jcouv merged commit 9297899 into dotnet:main Apr 18, 2023
@jjonescz jjonescz deleted the 67565-nameof-feature branch April 18, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants