Use discarded use site info for LookupSymbols scenario #67935
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Community
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
Youssef1313
commented
Apr 23, 2023
Comment on lines
+43
to
+45
| var useSiteInfo = discardUseSiteInfo | ||
| ? CompoundUseSiteInfo<AssemblySymbol>.Discarded | ||
| : CompoundUseSiteInfo<AssemblySymbol>.DiscardedDependencies; |
There was a problem hiding this comment.
This may have a behavioral change, but let's see if it will be captured by tests and check whether it's an important scenario for LookupSymbols or not.
AlekseyTs
reviewed
Apr 24, 2023
| @@ -55,7 +57,7 @@ public static MethodSymbol Create(MethodSymbol method, TypeSymbol receiverType, | |||
| return null; | |||
| } | |||
|
|
|||
| if (useSiteInfo.Diagnostics != null) | |||
| if (!discardUseSiteInfo && useSiteInfo.Diagnostics != null) | |||
AlekseyTs
requested changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming this change can be accepted, would it help with #67926 ? I'd like someone to confirm. cc @AlekseyTs @sharwell @CyrusNajmabadi