Avoid spinning attempting to create a folder #68394
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| { | ||
| // If we still can't create the folder after 5 seconds, assume we will not be able to create it. | ||
| // Return null to indicate this provider cannot provide source for the document. | ||
| return null; |
There was a problem hiding this comment.
Fine with this approach.
But I look at the caller here https://sourceroslyn.io/#Microsoft.CodeAnalysis.Features/MetadataAsSource/MetadataAsSourceFileService.cs,108
Looks like it assumes the return value of this method can't be null. (line 177)
So maybe we need to handle the failed case more properly, instead of throwing the unreachable exception.
There was a problem hiding this comment.
Ah, I misread the null check in the caller.
There was a problem hiding this comment.
➡️ Rewrote this to continue as it did before, but to just skip writing the file to disk if the location is not accessible. Roslyn will treat the result as an empty document.
| // Mark read-only | ||
| new FileInfo(fileInfo.TemporaryFilePath).IsReadOnly = true; | ||
| // Mark read-only | ||
| new FileInfo(fileInfo.TemporaryFilePath).IsReadOnly = true; |
There was a problem hiding this comment.
Why are we creating a new FileInfo w/o using it?
There was a problem hiding this comment.
We are using the IsReadOnly setter.
➡️ This code did not change.
There was a problem hiding this comment.
This code did not change
Yea, I see that, just wondering if we should use this new FileInfo instead afterward.
| @@ -172,13 +195,16 @@ public DecompilationMetadataAsSourceFileProvider(IImplementationAssemblyLookupSe | |||
| } | |||
| } | |||
|
|
|||
| using (var textWriter = new StreamWriter(fileInfo.TemporaryFilePath, append: false, encoding: MetadataAsSourceGeneratedFileInfo.Encoding)) | |||
| if (!skipWritingFile) | |||
There was a problem hiding this comment.
What's the consequence of not creating the file? We'd simply try again the next time it was request?
There was a problem hiding this comment.
That seems to be the case. Also, the compilation that gets created for it will see an empty file at that location with an error about failing to load the file contents.
There was a problem hiding this comment.
Is it possible to show the golden bar here? Or just maybe log the DirectoryNotFoundException or UnauthorizedAccessException so we have some traces of what's going on here
There was a problem hiding this comment.
Looks like my question is asked in the preview comment : )
There was a problem hiding this comment.
We should still get that. I'm not sure how to force this situation locally so it's hard to test.
ghost
added this to the 
Fixes AB#1812892