Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makeNotNullMembersMaybeNull - skip primary constructor capture fields #68441

Merged
merged 1 commit into from
Jun 7, 2023
Merged

makeNotNullMembersMaybeNull - skip primary constructor capture fields #68441

merged 1 commit into from
Jun 7, 2023

Conversation

AlekseyTs
Copy link
Contributor

@AlekseyTs AlekseyTs commented Jun 5, 2023 •
edited by jcouv
Loading

Fixes #68384.

Relates to #65697

@AlekseyTs AlekseyTs requested review from jjonescz and cston June 5, 2023 15:02
@AlekseyTs AlekseyTs requested a review from a team as a code owner June 5, 2023 15:02
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jun 5, 2023
@jcouv jcouv self-assigned this Jun 5, 2023
jcouv
jcouv approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@AlekseyTs
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@AlekseyTs AlekseyTs enabled auto-merge (squash) June 6, 2023 12:43
@AlekseyTs AlekseyTs merged commit 724a31f into dotnet:main Jun 7, 2023
@ghost ghost added this to the Next milestone Jun 7, 2023
@allisonchou allisonchou mentioned this pull request Jun 16, 2023
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.7 P3 Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@cston cston cston approved these changes

@jjonescz jjonescz Awaiting requested review from jjonescz

Assignees

@jcouv jcouv

Labels
Area-Compilers Feature - Primary Constructors untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.7 P3
Development

Successfully merging this pull request may close these issues.

Invalid CS8602 calling base constructor when using primary constructors
4 participants
@AlekseyTs @cston @jcouv @RikkiGibson