Merge internal fork of LSP tools back into Roslyn #68461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/internal/_git/dotnet-roslyn into features/lsp_tools_host
NodeJS launched processes do not have a default error mode of 0 (the system default), so Windows Error Reporting won't work on the server process.
… dependencies directory Will allow us to avoid inserting extra assemblies with Roslyn DevKit that are already in the shared dependencies inserted by vs-green-server. Shared dependencies are loaded only withing the load context of the DevKit extension. Follow ups: - https://devdiv.visualstudio.com/DevDiv/_git/vscode-csharp-next/pullrequest/473154 - https://dev.azure.com/dnceng/internal/_git/dotnet-roslyn/pullrequest/31422
Adds Hot Reload brokered services to C# DevKit (red in the diagram) 
…v/dibarbet/merge_lsp_tools_host
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dibarbet
force-pushed
the
dev/dibarbet/merge_lsp_tools_host
branch
from
c29306a
to
cb093f2
Compare
dibarbet
force-pushed
the
dev/dibarbet/merge_lsp_tools_host
branch
from
cb093f2
to
6a9eb9e
Compare
4 tasks
CyrusNajmabadi
approved these changes
Jun 8, 2023
|
Speedometer and RPS both passed. This is good to go as soon as CI finishes |
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the internal fork of the LSP tools host code (powering the new pre release version of the C# extension) back into Roslyn main.
Insertion validation (internal) - https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/476965